nilsnh/rolodex

Watch

Fork 1

Make plugin-system #4

Closed

Arxcis wants to merge 0 commits from Arxcis/rolodex:main into main

Arxcis commented

2026-07-19 12:39:25 +02:00

Collaborator

Goal

Rewrite the core to make it feasible to add a plugins like facebook.js in a later PR.
I other words, make the extension extendable.

TODO before merging:

Test usage agains linkedin.com, to make sure this PR does not break existing functionality. Assignee: @nilsnh

Plugin interface

The interface between plugin(s) and popup.js could be discussed further, but this PR tries (so far) to keep the interface as it was found, just documenting it without breaking anything and without introducing anything new. The only tiny addition is the add a export const name = '<pluginname>', to make it possible to make popup.js 100% generic.

/**
 * interface Plugin {
 *   name:          string;
 *   vcardify:      (data: UserProfile) => string;
 *   isProfilePage: (unparsedUrl: string) => bool;
 *   extactData:    () => UserProfile;
 * }
 */

Moving two utility-functions to `vcard.js`

downloadFile()
base64EncodeProfileImage()

...was moved to vcard.js by necessity, as a result of the refactoring of popup.js and linkedin.js.

## Goal * Rewrite the core to make it feasible to add a plugins like `facebook.js` in a [later PR](https://code.on.nilsnh.no/Arxcis/rolodex/pulls/1/files). * I other words, make the extension extendable. ## TODO before merging: * Test usage agains `linkedin.com`, to make sure this PR does not break existing functionality. Assignee: @nilsnh ## Plugin interface The interface between plugin(s) and `popup.js` could be discussed further, but this PR tries (so far) to keep the interface as it was found, just documenting it without breaking anything and without introducing anything new. The only tiny addition is the add a `export const name = '<pluginname>'`, to make it possible to make `popup.js` 100% generic. ```js /** * interface Plugin { * name: string; * vcardify: (data: UserProfile) => string; * isProfilePage: (unparsedUrl: string) => bool; * extactData: () => UserProfile; * } */ ``` ## Moving two utility-functions to `vcard.js` ``` downloadFile() base64EncodeProfileImage() ``` ...was moved to `vcard.js` by necessity, as a result of the refactoring of `popup.js` and `linkedin.js`.

Arxcis added 1 commit

2026-07-19 12:39:26 +02:00

Make plugin-system 40db46fe7e

nilsnh commented

2026-07-19 13:57:34 +02:00

Owner

Thank you for your work! I like the direction. It might take some days for me to find time to review. Thank you for your patience.

Finding the right abstraction is something we'll have to explore (inspiration). :)

Hope it's okay that I might commit to this repo if/when I explore how to realize how this plugin system will work?

Thank you for your work! I like the direction. It might take some days for me to find time to review. Thank you for your patience. Finding the right abstraction is something we'll have to explore ([inspiration](https://sandimetz.com/blog/2016/1/20/the-wrong-abstraction)). :) Hope it's okay that I might commit to this repo if/when I explore how to realize how this plugin system will work?

👍 1

Arxcis commented

2026-07-19 15:31:08 +02:00

Author

Collaborator

You are more than welcome to contribute to this PR @nilsnh , in your own time🙏

Arxcis added 1 commit

2026-07-19 22:51:31 +02:00

vcard.js fix missing export e51e100e1f

Arxcis commented

2026-07-19 22:57:09 +02:00

Author

Collaborator

Update

Made a PR on top of this one, adding facebook.js. This also made it so I could test this plugin system with two plugins, which is better than testing with one 👍

See diff: Arxcis/rolodex#1/files

This concludes my transition away from Github, and the github.com/arxcis/rolodex-repo has now been permanently deleted 🥳

**Update** Made a [PR](https://code.on.nilsnh.no/Arxcis/rolodex/pulls/1/) on top of this one, adding `facebook.js`. This also made it so I could test this plugin system with two plugins, which is better than testing with one 👍 See diff: https://code.on.nilsnh.no/Arxcis/rolodex/pulls/1/files This concludes my transition away from Github, and the [github.com/arxcis/rolodex](https://github.com/Arxcis/rolodex)-repo has now been permanently deleted 🥳

❤️ 1

nilsnh referenced this pull request

2026-07-22 08:25:55 +02:00

pr-plugin-system #6

nilsnh commented

2026-07-22 08:27:56 +02:00

Owner

Your contributions have been merged in #6 . Thank you! :)

Your contributions have been merged in https://code.on.nilsnh.no/nilsnh/rolodex/pulls/6 . Thank you! :)

🎉 1

nilsnh closed this pull request

2026-07-22 08:27:56 +02:00