Added better handling of failed tag deserializations. It will no longer block plugin loading.
This commit is contained in:
parent
2eef3ae620
commit
1125b70500
2 changed files with 7 additions and 4 deletions
3
.gitignore
vendored
3
.gitignore
vendored
|
@ -1,4 +1,5 @@
|
|||
node_modules
|
||||
dist
|
||||
tmp
|
||||
*.zip
|
||||
*.zip
|
||||
.idea/
|
|
@ -94,14 +94,15 @@ module tagIt {
|
|||
//first deselect before we go to work
|
||||
this.iframeDocument.getSelection().removeAllRanges();
|
||||
|
||||
//deserialize ranges
|
||||
_.map(tagsToLoad, (tagToLoad) => {
|
||||
//deserialize ranges, remove the ones that fail.
|
||||
tagsToLoad = _.filter(tagsToLoad, (tagToLoad) => {
|
||||
try {
|
||||
tagToLoad.deserializedRange = rangy.deserializeRange(
|
||||
tagToLoad.serializedSelectionRange,
|
||||
this.iframeDocument.documentElement,
|
||||
this.iframeWindow
|
||||
);
|
||||
return true;
|
||||
} catch (e) {
|
||||
var errorMsg = `Error in rangy.js: Was not able to deserialize range.
|
||||
In other words: The page might have changed. Is not able
|
||||
|
@ -109,8 +110,9 @@ module tagIt {
|
|||
this.$log.debug(errorMsg);
|
||||
this.$log.debug("Couldn't load: " + tagToLoad.sense.word);
|
||||
this.$log.debug(e);
|
||||
return false;
|
||||
}
|
||||
});
|
||||
})
|
||||
|
||||
this.$log.debug('finished deserializing tags');
|
||||
|
||||
|
|
Loading…
Reference in a new issue